[Bug 761588] opusdec: no mono/stereo channel conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761588

--- Comment #38 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Vincent Penquerc'h from comment #36)
> (In reply to Sebastian Dröge (slomo) from comment #35)
> > Review of attachment 322464 [details] [review] [review]:
> > 
> > ::: ext/opus/gstopusdec.c
> > @@ +256,2 @@
> >      }
> > +    if (dec->n_channels == 0) {
> > 
> > Shouldn't this case go away and become the <= 2 one?
> 
> If downstream only supports 4 channels, that'd prevent negotiation, no ?

Yes, but it should. Because we would negotiate 2 channels and that would then
fail much later anyway. Without channels in the caps we can only support mono
or stereo.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.