[Bug 761588] opusdec: no mono/stereo channel conversion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761588

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #322470|none                        |needs-work
             status|                            |

--- Comment #39 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 322470:
 --> (https://bugzilla.gnome.org/review?bug=761588&attachment=322470)

Just that one more thing, then please push :) Or explain why you think the
current channels==0 handling in the patch is correct

::: ext/opus/gstopusdec.c
@@ +278,1 @@
     if (gst_structure_has_field (s, "rate"))

By construction, s always has the rate field now btw :)

@@ +284,1 @@
     if (gst_structure_has_field (s, "channels"))

And once you fixed the channels part it will have that field too always

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.