[Bug 760733] aggregator: Make API public and move audioaggregator into library

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jan 18 01:38:21 PST 2016


https://bugzilla.gnome.org/show_bug.cgi?id=760733

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Thibault Saunier from comment #4)
> Review of attachment 319200 [details] [review]:
> 
> Looks like here the finish vfunc is not actually finishing, I guess you
> should rather have the ->finish vfunc default implementation do what we
> currently do outside the vmethod and ask subclasses to linkup.

Or should we maybe add something to GstAggregator that allows overriding
finish()? This patch was not meant to go in here anyway, should've been in
another bug :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list