[Bug 760733] aggregator: Make API public and move audioaggregator into library

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jan 18 01:39:42 PST 2016


https://bugzilla.gnome.org/show_bug.cgi?id=760733

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tsaunier at gnome.org

--- Comment #9 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Sebastian Dröge (slomo) from comment #8)
> (In reply to Thibault Saunier from comment #4)
> > Review of attachment 319200 [details] [review] [review]:
> > 
> > Looks like here the finish vfunc is not actually finishing, I guess you
> > should rather have the ->finish vfunc default implementation do what we
> > currently do outside the vmethod and ask subclasses to linkup.
> 
> Or should we maybe add something to GstAggregator that allows overriding
> finish()? This patch was not meant to go in here anyway, should've been in
> another bug :)

ok, let's get the rest in and talk about that in another bug. It might indeed
make sense to move that virtual method in GstAggregator itself.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list