[Bug 760757] gstsystemclock: incorrect handling of wait requests

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760757

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 319277:
 --> (https://bugzilla.gnome.org/review?bug=760757&attachment=319277)

::: gst/gstsystemclock.c
@@ +488,3 @@
+      /* mark the entry as busy but watch out for intermediate unscheduled
+       * statuses */
+    } while (G_UNLIKELY (!CAS_ENTRY_STATUS (entry, status, GST_CLOCK_BUSY)));

This looks like a lockless routine run with the object lock held. Sounds risky,
are you sure this go well in real-world cases ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.