[Bug 760757] gstsystemclock: incorrect handling of wait requests

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760757

--- Comment #5 from Florin Apostol <florin.apostol at oregan.net> ---
(In reply to Nicolas Dufresne (stormer) from comment #4)
> Review of attachment 319277 [details] [review]:
> 
> ::: gst/gstsystemclock.c
> @@ +488,3 @@
> +      /* mark the entry as busy but watch out for intermediate unscheduled
> +       * statuses */
> +    } while (G_UNLIKELY (!CAS_ENTRY_STATUS (entry, status,
> GST_CLOCK_BUSY)));
> 
> This looks like a lockless routine run with the object lock held. Sounds
> risky, are you sure this go well in real-world cases ?

>From what I know it is safe to perform atomic operations while holding a lock. 
Do you have any specific concerns?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.