[Bug 760733] aggregator: Make API public and move audioaggregator into library

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760733

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivier.crete at ocrete.ca

--- Comment #10 from Olivier Crête <olivier.crete at ocrete.ca> ---
Two things I'd like to see before freezing the APIs:

1. Have a ->negotiate() or similar vfunc in GstAggregator, and then have
generic implementations in audioaggregator and videoaggregator. Both audio and
video aggregator have code to move the handling of the caps event to the start
of the ->aggregate() vfunc. Also, all the buffer pool/allocator "negotiation"
code is currently done correctly in the glvideomixer class and the non-gl
specific bits should go upwards to the base class.

2. The pad and element object locks are held across the call to
->aggregate_one_buffer() in GstAudioAggregator. It was meant as a temporary
kludge, but I never got around to fixing it. We should probably release both
before calling the vfunc, but we should make sure that the object state is
still consistent afterwards.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.