[Bug 753760] rtph265: sync against latest spec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753760

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330940|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330940:
 --> (https://bugzilla.gnome.org/review?bug=753760&attachment=330940)

::: gst/rtp/gstrtph265depay.c
@@ +775,3 @@
+    ps = NULL;
+  } else {
+    ps = g_strdup_printf ("%s,%s,%s", vps, sps, pps);

It would probably be nicer to split this code apart so that each structure is
parsed independently instead of concatenating them all together just to tear
them apart again

::: gst/rtp/gstrtph265pay.c
@@ +307,2 @@
+      ptl[0] = value;
+      profile = gst_codec_utils_h265_get_profile (ptl, sizeof ptl);

Parenthesis for sizeof

@@ +404,3 @@
     gst_buffer_unmap (vps_buf, &map);

+    g_string_append_printf (vps, "%s%s", i ? "," : "", set);

You don't need GString for these anymore, the strings are always going to be
exactly set

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.