[Bug 753760] rtph265: sync against latest spec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753760

--- Comment #15 from Jonas Holmberg <jonas.holmberg at axis.com> ---
(In reply to Sebastian Dröge (slomo) from comment #14)
> Review of attachment 330940 [details] [review]:
> 
> ::: gst/rtp/gstrtph265depay.c
> @@ +775,3 @@
> +    ps = NULL;
> +  } else {
> +    ps = g_strdup_printf ("%s,%s,%s", vps, sps, pps);
> 
> It would probably be nicer to split this code apart so that each structure
> is parsed independently instead of concatenating them all together just to
> tear them apart again

Yes, I agree. But I was thinking that it could be done in a later commit since
it requires a bit of refactoring?

> 
> ::: gst/rtp/gstrtph265pay.c
> @@ +307,2 @@
> +      ptl[0] = value;
> +      profile = gst_codec_utils_h265_get_profile (ptl, sizeof ptl);
> 
> Parenthesis for sizeof

OK. It's only needed when operand is a type name iirc, but there's no harm in
having them.

> 
> @@ +404,3 @@
>      gst_buffer_unmap (vps_buf, &map);
>  
> +    g_string_append_printf (vps, "%s%s", i ? "," : "", set);
> 
> You don't need GString for these anymore, the strings are always going to be
> exactly set

How do you mean? Each one of the three lists (vps, sps and pps) has to be comma
separated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.