[Bug 768602] EGL_DMA_Buf: Wrong attribute list type for EGL 1.5

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768602

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #331391|none                        |needs-work
             status|                            |

--- Comment #11 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 331391:
 --> (https://bugzilla.gnome.org/review?bug=768602&attachment=331391)

::: gst-libs/gst/gl/egl/gsteglimage.c
@@ +277,3 @@
+    attribs_1_5[atti] = EGL_NONE;
+    for (int i = 0; i < atti; i++)
+      GST_LOG ("attr %i: %08X", i, attribs_1_5[i]);

I think the string format is not correct here. Should probably be
G_GUINTPTR_FORMAT.

@@ +304,3 @@

+#ifdef EGL_VERSION_1_5
+  if (GST_GL_CHECK_GL_VERSION (context->majorVersion, context->minorVersion,
1, 5)) {

I would just duplicate the assertions rather then doing the run-time check
twice.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.