[Bug 768602] EGL_DMA_Buf: Wrong attribute list type for EGL 1.5

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768602

--- Comment #12 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 331391:
 --> (https://bugzilla.gnome.org/review?bug=768602&attachment=331391)

I was trying to think of a way to deduplicate the attribute declarations across
both EGL versions and the only thing that I could see that made sense was
allocating some memory to hold the attributes and performing pointer arithmetic
to set the parameters.  Kind of like what GArray does.  This is more a
suggestion though if you feel like implementing that.

::: gst-libs/gst/gl/egl/gsteglimage.c
@@ +279,3 @@
+      GST_LOG ("attr %i: %08X", i, attribs_1_5[i]);
+  } else {
+#endif

This should be:

} else
#endif
{

to avoid the #ifdef at the end of the block

@@ +308,3 @@
+        EGL_LINUX_DMA_BUF_EXT, NULL, attribs_1_5);
+  } else {
+#endif

} else
#endif
{

::: gst-libs/gst/gl/gstglcontext.h
@@ +74,3 @@

+  gint majorVersion;
+  gint minorVersion;

No camelCase please.

Should be major/minor_version

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.