[Bug 768326] Building GStreamer for Android fails on Windows (new since 1.8.2)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768326

--- Comment #9 from Andy Devar <andy.devar at gmail.com> ---
>
>Not sure why this would be a new problem though
>

This is a new problem:
In older versions of gstreamer-1.0.mk, multiple separate calls of sed were used
to perform the replacements, e.g.:

    @$(HOST_ECHO) "GStreamer      : [GEN] => $(PRIV_C)"
    @$(call host-mkdir,$(PRIV_B_DIR))
    @$(call host-cp,$(PRIV_C_IN),$(PRIV_C))
    @$(SED) -i "s/@PLUGINS_DECLARATION@/$(PRIV_P_D)/g" $(PRIV_C)
    @$(SED) -i "s/@PLUGINS_REGISTRATION@/$(PRIV_P_R)/g" $(PRIV_C)
    @$(SED) -i "s/@G_IO_MODULES_LOAD@/$(PRIV_G_L)/g" $(PRIV_C)
    @$(SED) -i "s/@G_IO_MODULES_DECLARE@/$(PRIV_G_R)/g" $(PRIV_C)


In the 1.8.2 version of gstreamer-1.0.mk, a sequence of piped sed calls is used
to perform the replacements:

    @$(HOST_ECHO) "GStreamer      : [GEN] => $(PRIV_C)"
    @$(call host-mkdir,$(PRIV_B_DIR))
    cat $(PRIV_C_IN) | \
        $(SED) "s/@PLUGINS_DECLARATION@/$(PRIV_P_D)/g" | \
        $(SED) "s/@PLUGINS_REGISTRATION@/$(PRIV_P_R)/g" | \
        $(SED) "s/@G_IO_MODULES_LOAD@/$(PRIV_G_L)/g" | \
        $(SED) "s/@G_IO_MODULES_DECLARE@/$(PRIV_G_R)/g" > $(PRIV_C)

On Windows OS, the latter only works if at least one of the following
conditions is true:
- $(SED) is enclosed in double-quotes:
"C:/path/to/sed" | "C:/path/to/sed"
I think that this would be the better option, as it probably would also work if
the sed path contained spaces.
- The path contained in $(SED) has windows specific path separators only
(backslash instead of forward slash)
C:\path\to\sed | C:\path\to\sed




>
> Or should the content of the SED variable maybe contain the " on Windows?
>
I had also tried this, but it didn't work for some reason.
I'll try it again. If it works, I'll create a patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.