[Bug 768266] vaapi: Replace vappiminiobject with gst(mini)object

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jul 26 09:40:14 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=768266

--- Comment #16 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Three things:

1\ I wonder if we should keep gstvaapidisplay*_priv.h header files for
GstVaapiDisplay with this change. If we keep them, then we should use them by
hiding all the non-public data structures. Or if we follow the normal gstreamer
convertion, removing the gstvaapidisplay*_priv.h and exposing the data
structures/methods.

2\ I think we should try to use the API for g_autoptr()

3\ The commit logs should be more detailed about what is the commit about and
if that specific commit breaks the build or the normal usage of the elements.
This important if we later need to run a bisect.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list