[Bug 768266] vaapi: Replace vappiminiobject with gst(mini)object

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768266

--- Comment #17 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #16)
> Three things:
> 
> 1\ I wonder if we should keep gstvaapidisplay*_priv.h header files for
> GstVaapiDisplay with this change. If we keep them, then we should use them
> by hiding all the non-public data structures. Or if we follow the normal
> gstreamer convertion, removing the gstvaapidisplay*_priv.h and exposing the
> data structures/methods.

That's what I worked at first.
- expose public structures in *.h
- hide private structures in *.c and provide apis to access private members.
This would be much better than my current patches.

But, it needs much more change from current code.
We should do this at once? or do step by step.

> 2\ I think we should try to use the API for g_autoptr()
You mean g_autoptr support for vaapidisplay type? 
Good idea, but IMO, it needs in the second step when making it public.

> 3\ The commit logs should be more detailed about what is the commit about
> and if that specific commit breaks the build or the normal usage of the
> elements. This important if we later need to run a bisect.
Okay

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.