[Bug 766419] videotimecode: Added support for SMPTE time code metadata

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766419

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328273|none                        |needs-work
             status|                            |

--- Comment #25 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 328273:
 --> (https://bugzilla.gnome.org/review?bug=766419&attachment=328273)

Should there also be something for the video sink to send timecodes to the
hardware?

::: sys/decklink/gstdecklink.cpp
@@ +754,3 @@
+      res =
+          video_frame->
+          GetTimecode (GST_DECKLINK_VIDEO_SRC (videosrc)->timecode_format,

Put a FIXME comment here, it's not nice that there's this circularity between
gstdecklink.cpp and gstdecklinkvideosrc.cpp but also not that much of a problem

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +532,3 @@
     CaptureFrame *f;
+    const GstDecklinkMode *bmode;
+    GstVideoTimeCodeFlags flags = (GstVideoTimeCodeFlags) 0;

GST_VIDEO_TIME_CODE_FLAGS_NONE

@@ +533,3 @@
+    const GstDecklinkMode *bmode;
+    GstVideoTimeCodeFlags flags = (GstVideoTimeCodeFlags) 0;
+    guint field_count = 1;

Should be 0 for progressive

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.