[Bug 766419] videotimecode: Added support for SMPTE time code metadata

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766419

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328394|none                        |needs-work
             status|                            |

--- Comment #26 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 328394:
 --> (https://bugzilla.gnome.org/review?bug=766419&attachment=328394)

... and here the patch for the video sink is :)

::: sys/decklink/gstdecklinkvideosink.cpp
@@ +366,3 @@
+    flags = bmdVideoOutputVITC;
+  else
+    flags = bmdVideoOutputRP188;

This needs some documentation: why are all of them either mapping to one or
another?

Also what happens now if you enable timecode output (which you always do) but
never provide timecodes? Does it have different behaviour on the output side,
e.g. outputting a zero-timecode now while outputting nothing before?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.