[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329388|none                        |needs-work
             status|                            |

--- Comment #143 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329388:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=329388)

::: gst/rtp/gstrtpj2kdepay.c
@@ +203,3 @@
+  } else {
+    GST_ELEMENT_ERROR (depayload, STREAM, DEMUX, NULL,
+        ("Non-compliant stream: sampling field missing. Frames my appear
incorrect"));

This should be a warning, not an error :) An error would (in 99% of all
applications) cause the pipeline to be stopped

@@ +212,3 @@
+        sampling = GST_RTP_J2K_GRAYSCALE;
+      } else if (!strcmp (colorspace, "sRGB")) {
+        sampling = GST_RTP_J2K_RGB;

It might be BGR, let's keep it empty

::: gst/rtp/gstrtpj2kpay.c
@@ -58,3 @@
     GST_STATIC_CAPS ("application/x-rtp, "
-        "  media = (string) \"video\", "
-        "  payload = (int) " GST_RTP_PAYLOAD_DYNAMIC_STRING ", "

You removed the payload field

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.