[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329402|none                        |needs-work
             status|                            |

--- Comment #144 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329402:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=329402)

::: gst/videoparsers/gstjpeg2000parse.c
@@ +46,2 @@
     GST_PAD_ALWAYS,
+    GST_STATIC_CAPS ("image/x-jpc," GST_RTP_J2K_SAMPLING_LIST ";"
"image/x-jpc")

Shouldn't we require either of the two? You now require none

@@ +232,1 @@
   colorspace = gst_structure_get_string (current_caps_struct, "colorspace");

colorspace might be NULL now, but you don't handle that below

@@ +337,2 @@
+    if (colorspace) {
+      gst_caps_set_simple (src_caps, "colorspace", G_TYPE_STRING, colorspace,

If we require either colorspace or sampling, we can always set colorspace

@@ +341,3 @@
+
+    /* if we weren't able to determine the sampling, try to get from sink caps
*/
+    if (!sampling) {

Above we were only guessing the sampling for most cases. I think it would be
better to get the sampling from the caps in any case, and then only sanity
check that value (and warn if there is a mismatch, and for YUV correct the
subsampling at least)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.