[Bug 767463] windows static build broken (regression)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767463

--- Comment #2 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
What's happening is that linking executables is failing because libtool can
only find static libraries to link to, and the header has declarations for a
shared library. So to fix this on the build bot, all we need to do is set
GST_STATIC_COMPILATION when we have --enable-static --disable-shared.

I will note that consumers of gstreamer on Windows that need to link to
gstreamer statically will have to define this in their build systems as well,
so we should add a comment mentioning this to the macro definition.

AFAIK, there is no way around this and every other project has the same
requirement. Windows is unique in being a platform that requires different
prototype declarations for symbols in static and shared libraries.

One note about the patch. We can just do this:

- #ifdef _WIN32
+ #if defined(_WIN32) && !defined(GST_STATIC_COMPILATION)

instead of nesting the check.

I'll cook up a patch for this soon.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.