[Bug 767463] windows static build broken (regression)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767463

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Core:

commit 54fa564e012aa2f5aeac7fce9a6df0f592724eb3
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Fri Jun 24 05:26:09 2016 +0530

    gstconfig.h: Don't use extern with dllexport

    GCC emits an error for this with -Werror:

    plugin.c:22:1: error: 'gst_plugin_desc' initialized and declared 'extern'
[-Werror]

    This matches how glib does symbol exporting.

    https://bugzilla.gnome.org/show_bug.cgi?id=767463

commit 48088867db20094c8aafc7f50ce1bc0d8c633df5
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Tue Jun 21 19:49:15 2016 +0530

    win32: Don't use dllexport/import when only building statically

    If the prototypes in the public API have dllimport in them when building
    statically on Windows, the compiler will look for symbols with symbol
    mangling and indirection corresponding to a DLL. This will cause a build
    failure when trying to link tests/examples/etc.

    External users of GStreamer also need to define -DGST_STATIC_COMPILATION
    if they want to link to static gstreamer libraries on Windows.

    A similar version of this patch has been committed to all gstreamer
    repositories.

    https://bugzilla.gnome.org/show_bug.cgi?id=767463


-base:

commit d5ceb7ebb8b3d0cd033a7e963a84aaec4c542cb8
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Fri Jun 24 01:56:11 2016 +0530

    configure: Need to add -DGST_STATIC_COMPILATION when building only
statically

    https://bugzilla.gnome.org/show_bug.cgi?id=767463



-bad: 

commit 539c032345e3f063b5c166262aa7f7346a0d1e2f
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Fri Jun 24 01:57:13 2016 +0530

    configure: Need to add -DGST_STATIC_COMPILATION when building only
statically

    https://bugzilla.gnome.org/show_bug.cgi?id=767463



rtsp-server:

commit fc4f171f0fdfbbd164137dfd0ed687809fafa757
Author: Nirbheek Chauhan <nirbheek at centricular.com>
Date:   Fri Jun 24 02:02:20 2016 +0530

    configure: Need to add -DGST_STATIC_COMPILATION when building only
statically

    https://bugzilla.gnome.org/show_bug.cgi?id=767463


Let's see how that plays out on the build servers..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.