[Bug 730539] sdp: add support for multiple crypto sessions

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=730539

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329596|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329596:
 --> (https://bugzilla.gnome.org/review?bug=730539&attachment=329596)

Generally looks good, just some comments

::: gst/rtsp-server/rtsp-sdp.c
@@ +104,3 @@
+        break;
+      } else {
+        GST_WARNING ("unable to obtain ROC for stream with SSRC %u", ssrc);

That seems at the wrong place. You would warn now if the first ssrc is not what
you want, but the second is

@@ +131,3 @@
+
+  g_object_get (session, "sources", &sources, NULL);
+  for (i = 0; i < sources->n_values; i++) {

Could this be NULL?

@@ +140,3 @@
+    source = (GObject *) g_value_get_object (val);
+
+    g_object_get (source, "ssrc", &ssrc, "is-sender", &is_sender, NULL);

Maybe for efficiency, is-sender should be inside the stats structs too? That
way you would only have to iterate that one, right?

@@ +149,3 @@
+
+      if (stats) {
+        roc = get_roc_from_stats (stats, ssrc);

Should we fail if this returns -1? Probably?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.