[Bug 730539] sdp: add support for multiple crypto sessions

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=730539

--- Comment #15 from Aleix Conchillo Flaqué <aconchillo at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #14)
> Review of attachment 329596 [details] [review]:
> 
> Generally looks good, just some comments
> 
> ::: gst/rtsp-server/rtsp-sdp.c
> @@ +104,3 @@
> +        break;
> +      } else {
> +        GST_WARNING ("unable to obtain ROC for stream with SSRC %u", ssrc);
> 
> That seems at the wrong place. You would warn now if the first ssrc is not
> what you want, but the second is
> 

Oooops, yes, this goes outside.

> @@ +131,3 @@
> +
> +  g_object_get (session, "sources", &sources, NULL);
> +  for (i = 0; i < sources->n_values; i++) {
> 
> Could this be NULL?
> 

Added check.

> @@ +140,3 @@
> +    source = (GObject *) g_value_get_object (val);
> +
> +    g_object_get (source, "ssrc", &ssrc, "is-sender", &is_sender, NULL);
> 
> Maybe for efficiency, is-sender should be inside the stats structs too? That
> way you would only have to iterate that one, right?
> 

Yes, but I don't think we have access to the source in the srtpenc element.

> @@ +149,3 @@
> +
> +      if (stats) {
> +        roc = get_roc_from_stats (stats, ssrc);
> 
> Should we fail if this returns -1? Probably?

Added the warning from above instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.