[Bug 767512] jpeg2000parse: support j2c and jp2 file formats

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767512

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329701|none                        |reviewed
             status|                            |

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329701:
 --> (https://bugzilla.gnome.org/review?bug=767512&attachment=329701)

Looks good, unless you want to change the comment below as part of this commit
I'll merge it later or tomorrow :) Let me know

::: gst/videoparsers/gstjpeg2000parse.c
@@ +239,3 @@
+    /* check for "jp2c" */
+    j2c_box_id_offset = gst_byte_reader_masked_scan_uint32 (&reader,
0xffffffff,
+        GST_MAKE_FOURCC ('j', 'p', '2', 'c'), 0,

Isn't the box followed by the size of the whole frame? We could make use of
that :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.