[Bug 767512] jpeg2000parse: support j2c and jp2 file formats

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767512

--- Comment #19 from boxerab at gmail.com <boxerab at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #18)
> Review of attachment 329701 [details] [review]:
> 
> Looks good, unless you want to change the comment below as part of this
> commit I'll merge it later or tomorrow :) Let me know
> 
> ::: gst/videoparsers/gstjpeg2000parse.c
> @@ +239,3 @@
> +    /* check for "jp2c" */
> +    j2c_box_id_offset = gst_byte_reader_masked_scan_uint32 (&reader,
> 0xffffffff,
> +        GST_MAKE_FOURCC ('j', 'p', '2', 'c'), 0,
> 
> Isn't the box followed by the size of the whole frame? We could make use of
> that :)

Thanks. Actually, the size of the frame comes just before the fourcc.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.