[Bug 767402] OpenJPEG decoder: use new sampling field to determine channel order for j2c and jpc streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767402

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #329685|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 329685:
 --> (https://bugzilla.gnome.org/review?bug=767402&attachment=329685)

Why do you have the unrelated gstopenjpegenc.h changes in here? Also don't run
gst-indent on headers, it does ugly things with headers :)

::: ext/openjpeg/gstopenjpegdec.c
@@ +715,3 @@
+                GST_VIDEO_FORMAT_RGBA;
+          else
+            format = GST_VIDEO_FORMAT_ARGB;

How can self->sampling be NULL now? And why would it be BGRA or RGBA with
sampling, but ARGB otherwise? :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.