[Bug 767402] OpenJPEG decoder: use new sampling field to determine channel order for j2c and jpc streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767402

--- Comment #11 from boxerab at gmail.com <boxerab at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #10)
> Review of attachment 329685 [details] [review]:
> 
> Why do you have the unrelated gstopenjpegenc.h changes in here? Also don't
> run gst-indent on headers, it does ugly things with headers :)

Thanks, will fix this.

> 
> ::: ext/openjpeg/gstopenjpegdec.c
> @@ +715,3 @@
> +                GST_VIDEO_FORMAT_RGBA;
> +          else
> +            format = GST_VIDEO_FORMAT_ARGB;
> 
> How can self->sampling be NULL now? 

Good point, let me check on this

And why would it be BGRA or RGBA with
> sampling, but ARGB otherwise? :)

Well, ARGB is the default when we don't know the channel order. Otherwise, we
can use the sampling to decide on the order.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.