[Bug 768100] ghostpad: invalid ref getting internal pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768100

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330438|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330438:
 --> (https://bugzilla.gnome.org/review?bug=768100&attachment=330438)

::: gst/gstghostpad.c
@@ +507,3 @@
   internal = GST_PROXY_PAD_INTERNAL (pad);

+  GST_OBJECT_LOCK (internal);

Taking the object lock of the internal pad while we hold the one of the pad
seems dangerous here, especially when seeing the gst_object_unparent() further
below that might trigger going into another dispose().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.