[Bug 768100] ghostpad: invalid ref getting internal pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768100

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330439|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330439:
 --> (https://bugzilla.gnome.org/review?bug=768100&attachment=330439)

::: gst/gstghostpad.c
@@ +590,3 @@
     goto parent_failed;

+  GST_OBJECT_LOCK (internal);

construct() is supposed to be called exactly after instantiation of the object,
nothing else should have a reference to it other than this very thread that
runs construct().

When does this lead to problems?

@@ +842,3 @@
   internal = GST_PROXY_PAD_INTERNAL (gpad);

+  if (newtarget == internal) {

This would be a programming error and should get a g_return_val_if_fail() or
g_warning(). You should never set the internal pad as target of its ghostpad.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.