[Bug 768100] ghostpad: invalid ref getting internal pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768100

--- Comment #6 from Miguel París Díaz <mparisdiaz at gmail.com> ---
Review of attachment 330438:
 --> (https://bugzilla.gnome.org/review?bug=768100&attachment=330438)

::: gst/gstghostpad.c
@@ +507,3 @@
   internal = GST_PROXY_PAD_INTERNAL (pad);

+  GST_OBJECT_LOCK (internal);

The GST_PROXY_PAD_INTERNAL usage must be done holding the lock to avoid invalid
reference.

I reviewed the patch and made some tests, but I agree with you to be reviewed
carefully again.

@@ -511,2 @@
   /* disposes of the internal pad, since the ghostpad is the only possible
object
    * that has a refcount on the internal pad. */

This comment is related with this other:
https://github.com/Kurento/gstreamer/blob/2f41e7bc6a842044cb73bc0470601200575c378a/gst/gstghostpad.c#L589

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.