[Bug 768100] ghostpad: invalid ref getting internal pad

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768100

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330438:
 --> (https://bugzilla.gnome.org/review?bug=768100&attachment=330438)

::: gst/gstghostpad.c
@@ +507,3 @@
   internal = GST_PROXY_PAD_INTERNAL (pad);

+  GST_OBJECT_LOCK (internal);

In general your fix makes sense though, just needs careful checking if it can't
lead to a deadlock (which I did not do)

@@ -511,2 @@
   /* disposes of the internal pad, since the ghostpad is the only possible
object
    * that has a refcount on the internal pad. */

This comment also seems wrong :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.