[Bug 758232] Add support for EBU-TT-D / TTML subtitles

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758232

--- Comment #30 from Chris Bass <floobleflam at gmail.com> ---
(In reply to Reynaldo H. Verdejo Pinochet from comment #29)
> Review of attachment 329278 [details] [review]:

[...]

Thanks for the review. I've made most of the changes that you've suggested,
except for the ones about the functions that always return false:

> @@ +853,3 @@
> +  ttml_style_set_print (element->style_set);
> +
> +  return FALSE;
> 
> You don't need the boolean return if you always return FALSE

The reason for the boolean return is that all of these functions are passed to
g_node_traverse(), which expects a function of type GNodeTraverseFunc to be
passed, whose return type is gboolean.

[...]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.