[Bug 763065] androidmedia: assorted refactoring

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763065

--- Comment #18 from Martin Kelly <martin at surround.io> ---
OK, I've attached a patch attached to remove all the AHC*_CALL macros. After
writing it, I have mixed feelings about this patch. On one hand, the patch
results in about 400 lines of extra code, which is unfortunate. On the other
hand, it makes our Java calling conventions more standardized and provides
better error handling and logging. Overall, I think I'm in favor of this
change, but I'm curious what you think.

By the way, I checked the patch by a combination of code verification (as
carefully as I could), running a camera pipeline, and checking for obvious
signs of distress in adb. However, given the amount of code change here and the
fact that a lot of the affected code paths involve error cases, I'm not sure I
can test much more extensively. This is the kind of thing where we may just
need to let it stabilize in the tree for a while.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.