[Bug 763065] androidmedia: assorted refactoring

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763065

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323420|none                        |needs-work
             status|                            |

--- Comment #19 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 323420:
 --> (https://bugzilla.gnome.org/review?bug=763065&attachment=323420)

Looks good to me except for one detail. It's more code but also given much more
information, that's going to help a lot with debugging problems later.

::: sys/androidmedia/gst-android-hardware-camera.c
@@ +2181,3 @@
+    android_hardware_camera.addCallbackBuffer, buffer);
+  if (err) {
+    GST_ERROR ("Failed to call android.hardware.camera.addCallbackBuffer");

You probably want to include err->message in here... and everywhere else :) We
should print the information we have

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.