[Bug 763338] funnel: add 'forward-sticky-events-mode' property
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Mar 9 10:10:11 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=763338
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #323479|none |needs-work
status| |
--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 323479:
--> (https://bugzilla.gnome.org/review?bug=763338&attachment=323479)
::: plugins/elements/gstfunnel.c
@@ +67,3 @@
+
+ if (!mode_type) {
+ mode_type = g_enum_register_static ("FunnelForwardStickyEventsMode",
modes);
Prefix the type name with Gst
@@ +117,2 @@
static void
+gst_funneL_pad_finalize (GObject * gobject)
Maybe make that a lowercase L ;)
@@ +120,3 @@
+ GstFunnelPad *pad = GST_FUNNEL_PAD_CAST (gobject);
+
+ g_slist_free_full (pad->events_sent, (GDestroyNotify) gst_event_unref);
This should also be completely unneeded now. Or not?
@@ +176,3 @@
case PROP_FORWARD_STICKY_EVENTS:
+ GST_WARNING_OBJECT (funnel,
+ "'forward-stick-events' deprecated: use
'forward-stick-events-mode'");
You can let the property select ONCE / ALWAYS, right?
@@ +196,3 @@
case PROP_FORWARD_STICKY_EVENTS:
+ GST_WARNING_OBJECT (funnel,
+ "'forward-stick-events' deprecated: use
'forward-stick-events-mode'");
It should put *something* into the GValue at least, ideally you can translate
the new field.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list