[Bug 763338] funnel: add 'forward-sticky-events-mode' property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763338

--- Comment #6 from Miguel París Díaz <mparisdiaz at gmail.com> ---
Review of attachment 323479:
 --> (https://bugzilla.gnome.org/review?bug=763338&attachment=323479)

::: plugins/elements/gstfunnel.c
@@ +67,3 @@
+
+  if (!mode_type) {
+    mode_type = g_enum_register_static ("FunnelForwardStickyEventsMode",
modes);

Done

@@ +117,2 @@
 static void
+gst_funneL_pad_finalize (GObject * gobject)

What a fool mistake!!
Well seen ;)

Done

@@ +120,3 @@
+  GstFunnelPad *pad = GST_FUNNEL_PAD_CAST (gobject);
+
+  g_slist_free_full (pad->events_sent, (GDestroyNotify) gst_event_unref);

This is needed because pads can be removed without the elements goes to READY
state.

@@ +176,3 @@
     case PROP_FORWARD_STICKY_EVENTS:
+      GST_WARNING_OBJECT (funnel,
+          "'forward-stick-events' deprecated: use
'forward-stick-events-mode'");

Done

@@ +196,3 @@
     case PROP_FORWARD_STICKY_EVENTS:
+      GST_WARNING_OBJECT (funnel,
+          "'forward-stick-events' deprecated: use
'forward-stick-events-mode'");

Done

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.