[Bug 763441] rfbsrc: leads to -> invalid video buffer received

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763441

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323605|none                        |needs-work
             status|                            |

--- Comment #5 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 323605:
 --> (https://bugzilla.gnome.org/review?bug=763441&attachment=323605)

::: gst/librfb/gstrfbsrc.c
@@ +370,3 @@
   gst_buffer_pool_config_add_option (config,
GST_BUFFER_POOL_OPTION_VIDEO_META);

+  return gst_buffer_pool_set_config (pool, config);

Check you return value. This may return FALSE if the configuration had to be
changed. There is a helper for the general case, see
gst_buffer_pool_config_validate_params(). Also, enabling VideoMeta need to
depend on downstream having video meta.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.