[Bug 763441] rfbsrc: leads to -> invalid video buffer received

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763441

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Nicolas Dufresne (stormer) from comment #5)
> Review of attachment 323605 [details] [review]:
> 
> ::: gst/librfb/gstrfbsrc.c
> @@ +370,3 @@
>    gst_buffer_pool_config_add_option (config,
> GST_BUFFER_POOL_OPTION_VIDEO_META);
>  
> +  return gst_buffer_pool_set_config (pool, config);
> 
> Check you return value. This may return FALSE if the configuration had to be
> changed.

If the configuration had to be changed, what else than failing can we do? :)

> Also, enabling VideoMeta need to depend on downstream having video meta.

Yes, this was wrong before though, rfbsrc does not even need videometa or has
any advantage of it. And there's a lot similarly broken things in there. :)
This is for now only a WIP, someone with enough time can spend some more on it.
The current code is far from great.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.