[Bug 678207] lv2: port to GStreamer 1.0 and SLV2 to Lilv

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=678207

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #323148|none                        |reviewed
             status|                            |

--- Comment #7 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> ---
Review of attachment 323148:
 --> (https://bugzilla.gnome.org/review?bug=678207&attachment=323148)

Looks good already. I would be nice to submit and iterate. Are you goign to
also do the generators and do you want me to implement them?

::: ext/lv2/gstlv2filter.c
@@ +192,3 @@
+}
+
+#if 0

why is this disabled? Could you add a FIXME: comment? Or is it related to the
disabled code in gst_lv2_filter_setup()?

@@ +410,3 @@
+gst_lv2_filter_deinterleave_data (guint n_channels, gfloat * outdata,
+    guint samples, gfloat * indata)
+{

Can't we use the deinterleaved packing in the caps, or add a TODO for it?

@@ +452,3 @@
+  lv2_group = &lv2_class->in_group;
+
+  in = g_new0 (gfloat, nframes);

maybe special case channels=1 where we don't need extra in/out buffers and
deinterleave/interleave calls.

@@ +657,3 @@
+    g_free (ret);
+    ret = nret;
+  }

we should consider starting some bridge-utils library in base that has this
code.

@@ +824,3 @@
+
+  /* FIXME: not needed anymore when we can add pad templates, etc in
class_init
+   * as class_data contains the LADSPA_Descriptor too */

state comment?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.