[Bug 678207] lv2: port to GStreamer 1.0 and SLV2 to Lilv

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=678207

--- Comment #8 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 323148:
 --> (https://bugzilla.gnome.org/review?bug=678207&attachment=323148)

::: ext/lv2/gstlv2filter.c
@@ +410,3 @@
+gst_lv2_filter_deinterleave_data (guint n_channels, gfloat * outdata,
+    guint samples, gfloat * indata)
+{

Indeed, adding a TODO

@@ +452,3 @@
+  lv2_group = &lv2_class->in_group;
+
+  in = g_new0 (gfloat, nframes);

Yeah, for mono it is a bit useless, we should do it in LADSPA too I think we
have the same unoptimized behaviour.

@@ +657,3 @@
+    g_free (ret);
+    ret = nret;
+  }

Possible, not sure it is a big deal though.

@@ +824,3 @@
+
+  /* FIXME: not needed anymore when we can add pad templates, etc in
class_init
+   * as class_data contains the LADSPA_Descriptor too */

I just let that comment as it was, I am not sure I understand the idea.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.