[Bug 745187] JPEG2000 RTP video streaming problem

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745187

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327608|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327608:
 --> (https://bugzilla.gnome.org/review?bug=745187&attachment=327608)

::: gst/rtp/gstrtpj2kcommon.h
@@ +41,3 @@
+    J2K_MARKER_SOD = 0x93,
+    J2K_MARKER_EOC = 0xD9
+} RtpJ2KMarker;

The enum type and its values should also be properly namespaced

::: gst/rtp/gstrtpj2kdepay.c
@@ +25,3 @@
+ * and RFC 5372.
+ * For detailed information see: https://datatracker.ietf.org/doc/rfc5371/
+ * and https://datatracker.ietf.org/doc/rfc5372/

Can you put the documentation additions into a separate commit?

::: gst/rtp/gstrtpj2kpay.c
@@ +31,3 @@
+ * a JPEG 2000 tile-part header, or a JPEG 2000 packet.
+ *
+ * The standard recommends that headers be put in their own RTP packets.

And these. Also why is it noteworthy for the documentation that headers are
recommended to be put into their own RTP packets? :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.