[Bug 745187] JPEG2000 RTP video streaming problem

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745187

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327618|none                        |needs-work
             status|                            |

--- Comment #17 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327618:
 --> (https://bugzilla.gnome.org/review?bug=745187&attachment=327618)

Generally looks good

::: gst/rtp/gstrtpj2kpay.c
@@ +262,3 @@
+      will make T invalid.
+     This cannot happen in our case since we always
+     send tile headers in their own RTP packets, so we cannot mix

Should the sending of headers in their own packet maybe be a property? Might
not always be wanted (more overhead)

@@ +487,3 @@
+  /* set MHF to zero if there is no more main header to process */
+  if (state.header.MHF & 2)
+      state.header.MHF = 0;

Please run gst-indent over your commits

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.