[Bug 745187] JPEG2000 RTP video streaming problem

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745187

--- Comment #18 from boxerab at gmail.com <boxerab at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #17)
> Review of attachment 327618 [details] [review]:
> 
> Generally looks good

Thanks

> 
> ::: gst/rtp/gstrtpj2kpay.c
> @@ +262,3 @@
> + 	 will make T invalid.
> +	 This cannot happen in our case since we always
> +	 send tile headers in their own RTP packets, so we cannot mix
> 
> Should the sending of headers in their own packet maybe be a property? Might
> not always be wanted (more overhead)

I don't think the overhead is significant: most of the space is taken up by
the packet stream.  Can we make this an enhancement for a later date?
I just want to patch the defects for this ticket.


> 
> @@ +487,3 @@
> +  /* set MHF to zero if there is no more main header to process */
> +  if (state.header.MHF & 2)
> +	  state.header.MHF = 0;
> 
> Please run gst-indent over your commits

Will do.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.