[Bug 767011] rawparse: new rawaudioparse element which deprecates audioparse and unalignedaudioparse

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=767011

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328712|none                        |needs-work
             status|                            |

--- Comment #3 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 328712:
 --> (https://bugzilla.gnome.org/review?bug=767011&attachment=328712)

Finally, someone ports our "most simple format" parser to baseparse! Thank you!

gstrawaudiocommon.h  is common with what ?

::: gst/rawparse/gstrawaudioparse.c
@@ +706,3 @@
+        );
+
+    raw_audio_parse->src_caps_set = TRUE;

Why set this outside the lock?

@@ +822,3 @@
+    GST_ERROR_OBJECT (raw_audio_parse,
+        "only %" G_GSIZE_FORMAT " bytes available, which is not enough",
size);
+    flow_ret = GST_FLOW_ERROR;

This should never happen, you should just do a g_assert(). FYI, when returning
GST_FLOW_ERROR, you MUST post a message on the bus using GST_ELEMENT_ERROR(),
but in this case, g_assert() is enough.

@@ +923,3 @@
+       * bytes from a previous stream no longer apply.
+       * So, assume that no sink caps have ever been seen,
+       * and that the source pad caps have never been set. */

Is this true? I don't think stream start means that.

@@ +941,3 @@
+      GST_OBJECT_LOCK (raw_audio_parse);
+      gst_adapter_clear (raw_audio_parse->adapter);
+      raw_audio_parse->src_caps_set = FALSE;

flushes don't change the caps.

::: gst/rawparse/gstrawaudioparse.h
@@ +125,3 @@
+   * samples inside.
+   * The adapter is cleared during FLUSH_STOP and STREAM_START events. */
+  GstAdapter *adapter;

Why not use the adapter that's already in BaseParse? Setting the min_frame_size
means you should only get whole "frames".

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.