[Bug 768266] vaapi: Replace vappiminiobject with gst(mini)object

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768266

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #337550|none                        |reviewed
             status|                            |

--- Comment #35 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 337550:
 --> (https://bugzilla.gnome.org/review?bug=768266&attachment=337550)

while compiling I got this warning: 

gstvaapidisplay_wayland.c:212:27: warning: unused variable '_display'
[-Wunused-variable]                                                             
  GstVaapiDisplayWayland *_display = GST_VAAPI_DISPLAY_WAYLAND_CAST (display);  
                          ^

Anyway, as these are simple changes I'll change them and push this patch.

::: gst-libs/gst/vaapi/gstvaapidisplay.c
@@ +1113,2 @@
 GstVaapiDisplay *
+gst_vaapi_display_new (GstVaapiDisplay * display,

Let's keep we are breaking the gobject code conventions. This method is not
intended to be used by the API user, but the internal display decorators.

I would remove this method and use gst_vaapi_display_create() directly by the
decorator. But let's keep it for another iteration.

::: gst-libs/gst/vaapi/gstvaapidisplay_drm_priv.h
@@ +79,3 @@
+  gchar *device_path;
+  gint drm_device;
+  guint use_foreign_display:1;  // Foreign native_display?

Let's keep the C90 comment style

::: gst-libs/gst/vaapi/gstvaapidisplay_glx_priv.h
@@ +48,3 @@
   /*< private >*/
   GstVaapiDisplayX11 parent_instance;
+  GstVaapiTextureMap * texture_map;

This change is not required.

::: gst-libs/gst/vaapi/gstvaapidisplay_wayland.c
@@ +38,3 @@

+#define _do_init \
+    G_ADD_PRIVATE (GstVaapiDisplayWayland);

Did you forget the debug category initialization?

::: gst-libs/gst/vaapi/gstvaapidisplay_x11.c
@@ +48,3 @@

+#define _do_init \
+    G_ADD_PRIVATE (GstVaapiDisplayX11);

Did you forget the debug category initialization?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.