[Bug 768266] vaapi: Replace vappiminiobject with gst(mini)object

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Nov 2 13:50:11 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=768266

--- Comment #36 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 337550:
 --> (https://bugzilla.gnome.org/review?bug=768266&attachment=337550)

According to GObject conventions [1]: 

Create a macro named PREFIX_TYPE_OBJECT which always returns the GType for the
associated object type. 

Our prefix is GstVaapi, not Gst, we have to change all the macros.


1. https://developer.gnome.org/gobject/stable/gtype-conventions.html

::: gst-libs/gst/vaapi/gstvaapidisplay_priv.h
@@ +40,1 @@
+GType gst_vaapi_display_get_type (void);

we should set the attribute G_GNUC_CONST to all the _get_type() functions

http://wingolog.org/archives/2005/03/24/98

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list