[Bug 768266] vaapi: Replace vappiminiobject with gst(mini)object
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Nov 3 01:50:19 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=768266
--- Comment #39 from Hyunjun Ko <zzoon at igalia.com> ---
Review of attachment 337550:
--> (https://bugzilla.gnome.org/review?bug=768266&attachment=337550)
::: gst-libs/gst/vaapi/gstvaapidisplay.c
@@ +1113,2 @@
GstVaapiDisplay *
+gst_vaapi_display_new (GstVaapiDisplay * display,
Okay. I'll keep it in mind
::: gst-libs/gst/vaapi/gstvaapidisplay_priv.h
@@ +40,1 @@
+GType gst_vaapi_display_get_type (void);
Aha, good catch!
::: gst-libs/gst/vaapi/gstvaapidisplay_wayland.c
@@ +38,3 @@
+#define _do_init \
+ G_ADD_PRIVATE (GstVaapiDisplayWayland);
Well, I thought it's not neccesary because this category is already initialized
in gstvaapidisplay.c and could be refered by GST_DEBUG_CATEGORY_EXTERN.
::: gst-libs/gst/vaapi/gstvaapidisplay_x11.c
@@ +48,3 @@
+#define _do_init \
+ G_ADD_PRIVATE (GstVaapiDisplayX11);
same here.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list