[Bug 768266] vaapi: Replace vappiminiobject with gst(mini)object

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 3 02:02:18 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=768266

--- Comment #40 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #37)
> Review of attachment 337551 [details] [review]:
> 
> I don't feel this right.
> 
> GstVaapi{codecbuffer, context, image, subpicture, surface, pixmap_*,
> texture_*, window_*} should be GstMiniObject directly, not this convoluted
> way to share code with GstVaapiObject/GstVaapiMiniObject.
> 
> The purpose it to remove, in the future GstVaapiObject and
> GstVaapiMiniObject.

I understand what you mean.

But IIUC, GstMiniObject doesn't support inheritance properly.
Probably, this is also the reason why GstVaapiObject exists, because
GstVaapiMiniObject doesn't either.

If we remove GstVaapiObject totally, it means, we need to create something
similar to what GstVaapiObject's doing.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list