[Bug 773473] kmssink: support display mode setting

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=773473

--- Comment #16 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 338403:
 --> (https://bugzilla.gnome.org/review?bug=773473&attachment=338403)

::: sys/kms/gstkmssink.c
@@ +1163,3 @@
   GST_TRACE_OBJECT (self, "displaying fb %d", fb_id);

+  if (self->plane_id == -1) {

I would move this branch to avoid the cluttering of the function

@@ +1177,3 @@
+    waiting = TRUE;
+    ret = drmModePageFlip (self->fd, self->crtc_id, fb_id,
+        DRM_MODE_PAGE_FLIP_EVENT, &waiting);

is this possible if the driver doesn't support async page flip?

@@ +1178,3 @@
+    ret = drmModePageFlip (self->fd, self->crtc_id, fb_id,
+        DRM_MODE_PAGE_FLIP_EVENT, &waiting);
+    if (ret != 0)

if (ret)  -- to follow the current code style

@@ +1183,1 @@
+    while (waiting) {

perhaps we could avoid code duplication by making a function if this loop
waiting for an event

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.