[Bug 773473] kmssink: support display mode setting

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Nov 3 18:50:28 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=773473

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #338405|none                        |reviewed
             status|                            |

--- Comment #17 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 338405:
 --> (https://bugzilla.gnome.org/review?bug=773473&attachment=338405)

::: sys/kms/gstkmssink.c
@@ -910,3 @@
-      *end = *start + GST_BUFFER_DURATION (buf);
-    else {
-      if (GST_VIDEO_INFO_FPS_N (&self->vinfo) > 0) {

the only reason to use this method, is because, if the buffer doesn't have a
duration, a duration will be calculated with the provided framerate.

though I gladly remove this if we can foresee that this is not possible, nor
desirable.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list