[Bug 774030] postproc: return GST_FLOW_FLUSHING during flushing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=774030

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339220|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 339220:
 --> (https://bugzilla.gnome.org/review?bug=774030&attachment=339220)

::: gst/vaapi/gstvaapipostproc.c
@@ +812,2 @@
       GST_ERROR_OBJECT (postproc, "failed to push output buffer to video
sink");
+      return GST_FLOW_ERROR;

Why not "return ret"?

@@ +813,3 @@
+      return GST_FLOW_ERROR;
+    } else
+      return GST_FLOW_FLUSHING;

{}

@@ +891,2 @@
       GST_ERROR_OBJECT (postproc, "failed to push output buffer to video
sink");
+      return GST_FLOW_EOS;

Why not "return ret"?

@@ +892,3 @@
+      return GST_FLOW_EOS;
+    } else
+      return GST_FLOW_FLUSHING;

{}

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.